Uploaded image for project: 'WowModelViewer'
  1. WowModelViewer
  2. WMV-518

Demon hunter "no horns" customization still shows horns

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None
    • Platform:
      Windows 10
    • Platform type:
      64 bits

      Description

      For demon hunters, the first Horns customization variation (0) should display NO horns, but instead it shows the same horns as variation 1.

      I think this is because variation 0 doesn't have an entry in CharHairGeosets (the table which specifies the merged model and the horns geosets), so it seems we should assume that no horns geosets are used when there's no entry. Instead, WMV leaves them switched on because it hasn't explicitly been told to hide or remove them.

      It might be possible to fix this by keeping track of the merged model (in this case, the demon hunter collection model) used for each section and at the start of WoWModel::refresh() either:
      (1) hide all geosets on merged models used by sections, so only newly-specified geosets are switched on (later in the same func)
      or
      (2) delete all the merged models used by sections and only add them if newly-specified.

      The latter option might be cleaner. Especially if Blizzard ever specify different collections models for different customization options (currently it's always the same collections model for all options, or no model at all).

        Attachments

          Activity

            People

            • Assignee:
              Wain Wain
              Reporter:
              Wain Wain
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: